Code Review

Code that already looks finished, and is wrong. Find the defect before you submit — the tests it came with all pass.

Review: a paginated fetch that drops a page

The pagination helper below was generated, reviewed by its own tests, and shipped. It loses records. Find out which ones and why.

Review: the error that is not the error

advancedreview

A plugin system reports a failure in a plugin that is working correctly. The real failure happened earlier and was thrown away. Make the original error survive.

Review: a save-all that returns before saving

advancedreview

The batch-save helper below passes its tests — every item gets saved. It also returns an empty array to every caller. Find the async seam.